#1012 Cobertura report pulls functions from report scope, not the individual element #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cope, not the individual element
Codecov Report
@@ Coverage Diff @@
## 9.2 #1013 +/- ##
=========================================
Coverage 84.00% 84.00%
Complexity 1194 1194
=========================================
Files 61 61
Lines 4275 4275
=========================================
Hits 3591 3591
Misses 684 684
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you, @dvdoug! @SolovievEvgenii Can you test this, please? |
|
Good job @dvdoug ! I use cobertura reports every day and never noticed that it had issues with functions (I honestly never read them). Thanks for the fix. After testing these changes, the report looks way better. The coverage of the functions is not duplicated anymore. @sebastianbergmann You can wait @SolovievEvgenii to reply if you want but it looks good to me ! |
|
@bastien-phi Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haven't tested this myself yet, but SolovievEvgenii could you test to see if it works for you?