Revert "Reduce unnecessary IO"

This reverts commit c41f730.
sebastianbergmann · Dec 20, 2024 · 2c52441 · 2c52441
1 parent 0f46512
commit 2c52441
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/Data/RawCodeCoverageData.php b/src/Data/RawCodeCoverageData.php
@@ -16,8 +16,10 @@
 use function array_intersect_key;
 use function array_map;
 use function count;
-use function file;
+use function explode;
+use function file_get_contents;
 use function in_array;
+use function is_file;
 use function preg_replace;
 use function range;
 use function str_ends_with;
@@ -267,11 +269,13 @@ private function getEmptyLinesForFile(string $filename): array
         if (!isset(self::$emptyLineCache[$filename])) {
             self::$emptyLineCache[$filename] = [];
 
-            $sourceLines = @file($filename) ?: [];
+            if (is_file($filename)) {
+                $sourceLines = explode("\n", file_get_contents($filename));
 
-            foreach ($sourceLines as $line => $source) {
-                if (trim($source) === '') {
-                    self::$emptyLineCache[$filename][] = ($line + 1);
+                foreach ($sourceLines as $line => $source) {
+                    if (trim($source) === '') {
+                        self::$emptyLineCache[$filename][] = ($line + 1);
+                    }
                 }
             }
         }

diff --git a/src/StaticAnalysis/CachingFileAnalyser.php b/src/StaticAnalysis/CachingFileAnalyser.php
@@ -13,6 +13,7 @@
 use function file_get_contents;
 use function file_put_contents;
 use function implode;
+use function is_file;
 use function md5;
 use function serialize;
 use function unserialize;
@@ -168,14 +169,12 @@ private function read(string $filename): array|false
     {
         $cacheFile = $this->cacheFile($filename);
 
-        $contents = @file_get_contents($cacheFile);
-
-        if ($contents === false) {
+        if (!is_file($cacheFile)) {
             return false;
         }
 
         return unserialize(
-            $contents,
+            file_get_contents($cacheFile),
             [
                 'allowed_classes' => [
                     Class_::class,