When key is not found when fetching a specific event report, None is …

…returned to be consistent with the server-side API
seatsio · Nov 20, 2018 · 1a097e1 · 1a097e1
1 parent dd39a23
commit 1a097e1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/SeatsioDotNet.Test/EventReports/EventReportsTest.cs b/SeatsioDotNet.Test/EventReports/EventReportsTest.cs
@@ -89,6 +89,17 @@ public void BySpecificStatus()
             var report = Client.EventReports.ByStatus(evnt.Key, "lolzor");
 
             Assert.Equal(2, report.Count());
+        }    
+
+        [Fact]
+        public void BySpecificNonExistingStatus()
+        {
+            var chartKey = CreateTestChart();
+            var evnt = Client.Events.Create(chartKey);
+
+            var report = Client.EventReports.ByStatus(evnt.Key, "lolzor");
+
+            Assert.Null(report);
         }
 
         [Fact]

diff --git a/SeatsioDotNet/EventReports/EventReports.cs b/SeatsioDotNet/EventReports/EventReports.cs
@@ -116,7 +116,11 @@ private IEnumerable<EventReportItem> FetchReport(string reportType, string event
                 .AddUrlSegment("reportType", reportType)
                 .AddUrlSegment("filter", filter);
             var report = AssertOk(_restClient.Execute<Dictionary<string, IEnumerable<EventReportItem>>>(restRequest));
-            return report[filter];
+            if (report.ContainsKey(filter))
+            {
+                return report[filter];
+            }
+            return null;
         }
     }
 }
diff --git a/SeatsioDotNet/SeatsioDotNet.csproj b/SeatsioDotNet/SeatsioDotNet.csproj
@@ -2,7 +2,7 @@
   <PropertyGroup>
     <OutputType>Library</OutputType>
     <IsPackable>true</IsPackable>
-    <Version>46</Version>
+    <Version>47</Version>
     <Authors>mroloux;bverbeken</Authors>
     <Title>Official Seats.io .NET API client</Title>
     <Description>Official Seats.io .NET API client</Description>