This repository has been archived by the owner on Sep 16, 2024. It is now read-only.
feat: record environment id in service resource. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thxCode <[email protected]>
Signed-off-by: thxCode <[email protected]>
- return the related ids of a service and service resource in the graph apis Signed-off-by: thxCode <[email protected]>
thxCode
requested review from
alexcodelf,
gitlawr and
aiwantaozi
and removed request for
alexcodelf and
gitlawr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
Failed to operate(log/exec) the vertex from the environment graph(multiple services), as there is no field to represent the owned service of a service resource from the response payload.
Solution:
environement_idinto ServiceResource, like what we did to ServiceRevision, redunt, but efficient. @hibig @Finenyaco , need to rebuild the database.projectID,environmentIDandserviceIDto the vertexextensionsfield from the graph response payload. @hibigRelated Issue: