Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

refactor: clarify tls mode #1095

Merged
merged 1 commit into from
Aug 16, 2023
Merged

refactor: clarify tls mode #1095

merged 1 commit into from
Aug 16, 2023

Conversation

thxCode
Copy link
Member

@thxCode thxCode commented Aug 16, 2023

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

We blind on the server listening mode, especially, the TLS mode.

Solution:

Log the server listening mode, and mutate the useless error log from HTTP standard server.

Related Issue:

Copy link
Contributor

@alexcodelf alexcodelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gitlawr gitlawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gitlawr gitlawr merged commit d895675 into seal-io:main Aug 16, 2023
3 checks passed
@thxCode thxCode deleted the tls branch August 18, 2023 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants