Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

fix: catalog import non-terraform modules #1056

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Conversation

alexcodelf
Copy link
Contributor

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

  1. Clone self-host repository failed, missing port when parsing url
  2. Import catalog create non-terraform repository as a template, import timeout

Solution:

  1. fix parse self-host url,keep port of url.
  2. validate template version schema before create template and template version, remove 5 min timeout for sync catalog.

Related Issue:
#1045 #1048 #1051

@alexcodelf alexcodelf changed the title Fix/catalog fix: catalog import non-terraform modules Aug 14, 2023
gitlawr
gitlawr previously approved these changes Aug 14, 2023
Copy link
Contributor

@gitlawr gitlawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@thxCode thxCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thxCode thxCode merged commit 08db66a into seal-io:main Aug 14, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants