fix(staging): seal-io/code-generator

seal-io · Mar 27, 2024 · 3658ca7 · 3658ca7
1 parent 23d7d01
commit 3658ca7
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 13 deletions.
diff --git a/staging/github.com/seal-io/code-generator/cmd/crd-gen/generators/helper.go b/staging/github.com/seal-io/code-generator/cmd/crd-gen/generators/helper.go
@@ -1065,7 +1065,7 @@ func collectMarkers(comments []string, into map[string][]string) {
 				into["validation"] = append(into["validation"], "default="+v)
 			}
 		case line == optionalMarker:
-			into["validation"] = append(into["validation"], "optional")
+			into["validation"] = append(into["validation"], "optional=true")
 		case strings.HasPrefix(line, listTypeMarker):
 			if v := line[len(listTypeMarker):]; v != "" {
 				into["validation"] = append(into["validation"], "listType="+v)

diff --git a/...b.com/seal-io/code-generator/cmd/crd-gen/generators/testdata/crd_gen/zz_generated.crds.go b/...b.com/seal-io/code-generator/cmd/crd-gen/generators/testdata/crd_gen/zz_generated.crds.go
diff --git a/...l-io/code-generator/cmd/crd-gen/generators/testdata/crd_gen/zz_generated.crds.go.expected b/...l-io/code-generator/cmd/crd-gen/generators/testdata/crd_gen/zz_generated.crds.go.expected
@@ -70,10 +70,6 @@ func crd_crd_gen_generators_testdata_crd_gen_Dummy() *v1.CustomResourceDefinitio
 								"spec": {
 									Type: "object",
 									Required: []string{
-										"integer",
-										"float",
-										"string",
-										"bool",
 										"integerPointer",
 										"floatPointer",
 										"stringPointer",

diff --git a/...hub.com/seal-io/code-generator/cmd/crd-gen/generators/testdata/reflect_type/expected.yaml b/...hub.com/seal-io/code-generator/cmd/crd-gen/generators/testdata/reflect_type/expected.yaml
@@ -284,10 +284,6 @@ spec:
                 nullable: true
                 type: string
             required:
-            - integer
-            - float
-            - string
-            - bool
             - integerPointer
             - floatPointer
             - stringPointer