Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes package #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes package #18

wants to merge 2 commits into from

Conversation

a-tal
Copy link

@a-tal a-tal commented Dec 18, 2019

Currently when you try to pull this package in as a dependancy you get an exit 1 error code from pip, due to pulling in futures without it being a hard requirement, as well as the syntax errors below.

Please push a new package to PyPI after accepting this PR

  File "build/bdist.macosx-10.14-x86_64/egg/requests_throttler/example.py", line 35
    print r.response
          ^
SyntaxError: Missing parentheses in call to 'print'. Did you mean print(r.response)?
This backport is meant only for Python 2.
It does not work on Python 3, and Python 3 users do not need it as the concurrent.futures package is available in the standard library.
For projects that work on both Python 2 and 3, the dependency needs to be conditional on the Python version, like so:
extras_require={':python_version == "2.7"': ['futures']}
error: Setup script exited with 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant