Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in a different docker build and push flow #109

Closed
wants to merge 4 commits into from

Conversation

jzucker2
Copy link
Contributor

@jzucker2 jzucker2 commented Nov 5, 2023

No description provided.

@jzucker2
Copy link
Contributor Author

jzucker2 commented Nov 5, 2023

Sorry, the new GitHub UI is awful, I thought I was opening this up on my local repo first. I wanted to test building on prs as well as releases

@peter-mcconnell
Copy link
Collaborator

Thanks for the PR @jzucker2 - I'm new as a maintainer here so apologies if I'm missing some context, but why the change in registries? The workflow you've provided looks solid - its just changing from docker hub to github repos gives me pause, as this would be a change in where users can look up the image / we'd need to clearly communicate such a change.

Sorry in advance if this was already discussed

@jzucker2
Copy link
Contributor Author

jzucker2 commented Nov 6, 2023

Wasn't discussed. I was trying to open this in my repo first, but GitHub's new PR UI is just awful and led me here instead. I couldn't track how the pr tags were generated in that custom docker action so I was just messing around with another approach. This is absolutely not ready for merging

@peter-mcconnell peter-mcconnell marked this pull request as draft November 6, 2023 22:53
@se1exin se1exin closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants