Recovery and Verification Flow #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratham1729
reviewed
Jan 4, 2024
api/settings.go
Outdated
| @@ -125,7 +137,7 @@ func HandleUpdateProfile(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| msg, err := settings.SubmitSettingsFlowProfileMethod(flow_cookie, session_cookie, req_body.FlowID, req_body.CsrfToken, req_body.Method, traitsinterface) | |||
| msg, err := settings.SubmitSettingsFlowProfileMethod(flow_cookie, session_cookie, req_body.FlowID, req_body.CsrfToken, traitsinterface) | |||
|
|
|||
| if err != nil { | |||
| log.ErrorLogger("Kratos post settings flow failed", err) | |||
There was a problem hiding this comment.
mention which specific flow failed, in this case profile
pratham1729
reviewed
Jan 4, 2024
api/settings.go
Outdated
| @@ -182,7 +194,7 @@ func HandleChangePassword(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| msg, err := settings.SubmitSettingsFlowPasswordMethod(flow_cookie, session_cookie, req_body.FlowID, req_body.CsrfToken, req_body.Method, req_body.Password) | |||
| msg, err := settings.SubmitSettingsFlowPasswordMethod(flow_cookie, session_cookie, req_body.FlowID, req_body.CsrfToken, req_body.Password) | |||
|
|
|||
| if err != nil { | |||
| log.ErrorLogger("Kratos post settings flow failed", err) | |||
pratham1729
reviewed
Jan 4, 2024
api/settings.go
Outdated
| @@ -239,7 +251,7 @@ func HandleToggleTOTP(c *gin.Context) { | |||
| return | |||
| } | |||
|
|
|||
| msg, err := settings.SubmitSettingsFlowTOTPMethod(flow_cookie, session_cookie, req_body.FlowID, req_body.CsrfToken, req_body.Method, req_body.TOTPCode, req_body.TOTPUnlink) | |||
| msg, err := settings.SubmitSettingsFlowTOTPMethod(flow_cookie, session_cookie, req_body.FlowID, req_body.CsrfToken, req_body.TOTPCode, req_body.TOTPUnlink) | |||
|
|
|||
| if err != nil { | |||
| log.ErrorLogger("Kratos post settings flow failed", err) | |||
pratham1729
reviewed
Jan 4, 2024
|
|
||
| if err != nil { | ||
| session_cookie, err1 := c.Cookie("sdslabs_session") | ||
| recovery_cookie, err2 := c.Cookie("ory_kratos_session") |
There was a problem hiding this comment.
maybe rename this from recovery_cookie to settings_cookie
pratham1729
reviewed
Jan 17, 2024
pkg/wrapper/kratos/admin/admin.go
Outdated
| "name": data.Name, | ||
| "password": data.Password, | ||
| "phone_number": data.PhoneNumber, | ||
| "active": true, |
There was a problem hiding this comment.
invite status is missing, active trait is present here
pratham1729
reviewed
Jan 17, 2024
| "email": req_body.Traits.Email, | ||
| "totp_enabled": req_body.Traits.TOTP_Enabled, | ||
| "created_at": req_body.Traits.Created_At, | ||
| "role": req_body.Traits.Role, |
There was a problem hiding this comment.
active trait is missing here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.