Require redis-client to ensure that constant is available

[hieuk09]

Fix #318

[sds]

Thank you

[bquorning]

Perhaps redis-client should be added as a dependency in gemspec?

[hieuk09]

Hmm, right, I think there should be. I was under assumption that redis 5 is the dependencies but now I realize that it is the development dependencies only.

@sds Should we add redis 5 as the dependencies of the gem?

[bquorning]

Ah, it turns out I was still using v4.8.1 of the redis gem which does not yet have a dependency on redis-client. The real problem may be that mock_redis lists 'redis', '~> 5' as a development dependency, and not as a runtime dependency:

mock_redis/mock_redis.gemspec

Line 38 in 9ae5e91

s.add_development_dependency 'redis', '~> 5'

[sds]

Can you clarify why this should be a runtime dependency when MockRedis is intended to be used for testing (i.e. development) only? Which use cases are people using it for where MockRedis is used in a production context?

[bquorning]

Development dependencies are the libraries you need while developing this gem. Runtime dependencies are the libraries I need while using this gem.

It doesn't really matter if I use your gem in a test or production capacity.

… that's how I understand it at least.

[sds]

Makes sense since by adding MockRedis as a development dependency all of its runtime dependencies also become development dependencies.

Addressed in 0.49.0. Thanks.