net/tls: Add a way to disable certificate validation #2546
+23
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p12tic
force-pushed
the
tls-cert-verification-disable
branch
from
f86ca7a
to
2456c3c
Compare
elcallio
approved these changes
Nov 25, 2024
|
Conflicts, please rebase (@p12tic ) |
This feature is useful when testing TLS client with a server that does not have proper certificates setup yet. The API to control this has been added to the certificate_credentials class because an instance of that class is already accepted by functions that may want to configure TLS. This way the requirement of additional set of overloads is avoided. Controlling certificate validation is not completely unrelated to what certificate_credentials already does. It effectively controls which server certificetes the client is going to accept. Calling set_enable_certificate_verification(true) effectively adds all possible certificates to the set of accepted certificates. set_priority_string() already offers a similar control on algorithm quality.
p12tic
force-pushed
the
tls-cert-verification-disable
branch
from
2456c3c
to
6b62deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is useful when testing TLS client with a server that does not have proper certificates setup yet.
The API to control this has been added to the certificate_credentials class because an instance of that class is already accepted by functions that may want to configure TLS. This way the requirement of additional set of overloads is avoided.
Controlling certificate validation is not completely unrelated to what certificate_credentials already does. It effectively controls which server certificetes the client is going to accept. Calling set_enable_certificate_verification(true) effectively adds all possible certificates to the set of accepted certificates. set_priority_string() already offers a similar control on algorithm quality.