Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reactor: Mark drain() private #2524

Merged
merged 1 commit into from
Nov 3, 2024
Merged

reactor: Mark drain() private #2524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/seastar/core/reactor.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,9 @@ private:

void configure(const reactor_options& opts);
int do_run();
// Waits for all background tasks on all shards
static future<> drain();

public:
explicit reactor(std::shared_ptr<smp> smp, alien::instance& alien, unsigned id, reactor_backend_selector rbs, reactor_config cfg);
reactor(const reactor&) = delete;
Expand Down Expand Up @@ -534,9 +537,6 @@ public:
run_in_background(futurize_invoke(std::forward<Func>(func)));
}

// Waits for all background tasks on all shards
static future<> drain();

/// Set a handler that will be called when there is no task to execute on cpu.
/// Handler should do a low priority work.
///
Expand Down