build: use find_dependency() instead find_package() in config file #2505
+53
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the loop and the helper variables do not help with the maintainability. the intention was to split the data and code, but it hurts the readability. in this change, we - remove the helper of `seastar_set_dep_args()` - add a helper of `seastar_find_dep()`. it will be used for adapting to `find_dependency()` in `SeastarConfig.cmake.in` - take this opportunity to add space before `(` to be consistent with the style in this file. Signed-off-by: Kefu Chai <[email protected]>
SeastarDependencies.cmake is used in two scenarios: - configure Seastar library, when building Seastar itself. - configure Seastar library, when a parent project tries to detect Seastar library. when building the Seastar application. in the second case, we should respect the "REQUIRED" and "QUIET" options passed to `find_package(Seastar)`. and CMake provides `find_dependency()` macro for this purpose. in this change, we conditionally call `find_dependency()` when `SeastarDependencies.cmake` is used when this script is called when finding Seastar library. this provides a better developer experience to Seastar developers. Signed-off-by: Kefu Chai <[email protected]>
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
1 similar comment
|
@scylladb/seastar-maint hello maintainers, could you help review this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SeastarDependencies.cmake is used in two scenarios:
detect Seastar library. when building the Seastar application.
in the second case, we should respect the "REQUIRED" and "QUIET"
options passed to
find_package(Seastar). and CMake providesfind_dependency()macro for this purpose.in this change, we conditionally call
find_dependency()whenSeastarDependencies.cmakeis used when this script is calledwhen finding Seastar library. this provides a better developer
experience to Seastar developers.