-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Use Rust cache #901
base: main
Are you sure you want to change the base?
CI: Use Rust cache #901
Conversation
036403e
to
a3a12fc
Compare
This adds caching to all CI jobs that use cargo
a3a12fc
to
cf31ddf
Compare
… install mdbook using `taiki-e/install-action@v2`
e94b83c
to
8f1da06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Do you know why the CI failed? Is it just a one-time fluke or some problem with PR / cache action / cargo?
Regarding the changes:
- First commit looks fine
- I don't understand the purpose of second commit. Could you describe in the body of commit message why is it beneficial to add the usage of
dtolnay/rust-toolchain
/taiki-e/install-action
? Also, could you rewrite the message to make it's title shorter? Right now it's wrapped around by GitHub.
Also, could you rebase on latest main
?
After you push the changes, the CI will run again so we'll know if the failure was just a one time error or some real problem.
- uses: dtolnay/rust-toolchain@master | ||
with: | ||
toolchain: stable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with the toolchain that is already on the runners?
uses: taiki-e/install-action@v2 | ||
with: | ||
tool: mdbook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the advantage of this?
Regarding timings: comparing durations here vs the last CI run from other PR:
It seems there are visible gains, so it would be nice to merge this PR. |
@oeb25 What's the status of this? |
This adds Swatinem/rust-cache@v2 to all CI jobs, with the intention of speeding them up. Hopefully we can compare some runs to get empirical data of the improvements it gives.
Pre-review checklist
./docs/source/
.Fixes:
annotations to PR description.