rust: appease compiler, formatter and linter from toolchain 1.83 #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warnings are regarding elision of named lifetimes.
See: https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes I applied the suggestion in places where we only use one lifetime. However, I disabled the lint in places where there is more than one lifetime. I believe, that having the lifetime explicit if there are many of them aids readability and makes the code easier to understand. There is a tracking issue for configuration of the lint. See: rust-lang/rust-clippy#12495
The lifetime was not used at all. The clippy complained about it (as it should).
|
|
wprzytula
approved these changes
Dec 2, 2024
wprzytula
added a commit
to wprzytula/scylla-rust-driver
that referenced
this pull request
Dec 11, 2024
rust: appease compiler, formatter and linter from toolchain 1.83 (cherry picked from commit 49c342e)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CI, by fixing the:
cargo fmtwere introduced in 1.83Pre-review checklist
[ ] I added relevant tests for new features and bug fixes.[ ] I have provided docstrings for the public items that I want to introduce.[ ] I have adjusted the documentation in./docs/source/.[ ] I added appropriateFixes:annotations to PR description.