Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 6.2] fix(test_user_batch_custom_time): handle stress command correctly #9374

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 26, 2024

seems like we were running into situations we try to add all nodes ips into stress commands, and it's the test code

File ".../longevity_test.py", line 300, in test_user_batch_custom_time
self._run_user_stress_in_batches(batch_size=batch_size,
File ".../longevity_test.py", line 336, in _run_user_stress_in_batches
batch_params['stress_cmd'] += [params['stress_cmd'] + nodes_ips]
TypeError: list indices must be integers or slices, not str

in this change remove a parentheses that was causing function to return tuple and not string as expected

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

(cherry picked from commit 8f16d05)

Parent PR: #9345

seems like we were running into situations we try to add all nodes ips into
stress commands, and it's the test code
```
File ".../longevity_test.py", line 300, in test_user_batch_custom_time
self._run_user_stress_in_batches(batch_size=batch_size,
File ".../longevity_test.py", line 336, in _run_user_stress_in_batches
batch_params['stress_cmd'] += [params['stress_cmd'] + nodes_ips]
TypeError: list indices must be integers or slices, not str
```

in this change remove a parentheses that was causing function to return
tuple and not string as expected

(cherry picked from commit 8f16d05)
@mergify mergify bot assigned fruch Nov 26, 2024
@fruch fruch merged commit 8ce3da4 into branch-6.2 Nov 26, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant