Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): remove --retry-all-errors from manager repo file download #9343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fruch
Copy link
Contributor

@fruch fruch commented Nov 24, 2024

since this flag is only supported from curl 7.71.0 and up, we should yet be using it.

The warnings on this flag kind of make it a bit less helpful in our case, cause it can end up with multiple data in the output, and break our the repo definition.

Ref: https://curl.se/docs/manpage.html#--retry-all-errors

Testing

  • artifact test

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

since this flag is only supported from curl 7.71.0 and up,
we should yet be using it.

The warnings on this flag kind of make it a bit less helpful
in our case, cause it can end up with multiple data in the
output, and break our the repo definition.

Ref: https://curl.se/docs/manpage.html#--retry-all-errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants