fix(raft): drop stale log pattern as trigger for interrupting decommission #9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssion
Since scylla commit 36520250623a ("storage_service: wire node_ops_ctl for
node operations", 2023-03-09), scylla does not log "Finished token ring
movement". Watching the log for this message would inevitably time out,
consequently. Remove this log pattern.
Fixes scylladb#9281
Signed-off-by: Laszlo Ersek <[email protected]>
lersek
added
backport/5.4
fruch
added
backport/2023.1
|
branch 5.4 isn't supported anymore. and we should label the enterprise branches in SCT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since scylladb/scylladb@36520250623a, scylla does not log "Finished token ring movement". Watching the log for this message would inevitably time out, consequently. Remove this log pattern.
Fixes #9281
The backporting question looks pretty bleak on this one:
scylla-5.3.0-rc0andscylla-5.4.0(in other words, even 5.4 no longer logsFinished token ring movement).This means that the patch should be backported minimally to branch-5.3 through branch-6.2 (because I presume those target identically-versioned, released scylla binaries, and those binaries no longer emit the message).
I don't know how the other SCT branch names (i.e., those that include a year number, or the word "perf") relate to scylla binary 5.3. Thus, those branches may or may not be backporting targets.