Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(custom-d1-w2): mgmt-repair + tombstone_gc=repair + HH + log_batch #9334

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

vponomaryov
Copy link
Contributor

@vponomaryov vponomaryov commented Nov 22, 2024

Add test that uses custom-d1/workload2 scenario configuration and add following changes:

  • Set tombstone_gc mode to be repair
  • Enable mgmt_repiar nemesis
  • Enable hinted_handoff feature
  • Use logged batch queries

All of the above will allow to repro following bugs:

Ref: https://github.com/scylladb/scylla-enterprise/issues/4284
Ref: https://github.com/scylladb/scylla-enterprise/issues/4602
Ref: https://github.com/scylladb/scylla-enterprise/issues/4588

Testing

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

Latte allows to provide custom parameters to rune scripts.
Latte creates schema using separate 'latte schema' command which we
call implicitly.

So, add possibility to specify custom parameters for the implicit call
of the 'latte schema' command.

Usage in a config file:

  latte_schema_parameters:
    tombstone_gc_mode: repair

or as part of the env var:

  export SCT_LATTE_SCHEMA_PARAMETERS.tombstone_gc_mode=repair
Add test that uses 'custom-d1/workload2' scenario configuration and
add following changes:
- Set 'tombstone_gc' mode to be 'repair'
- Enable 'mgmt_repiar' nemesis
- Enable hinted_handoff feature
- Use logged batch queries

All of the above will allow to repro following bugs:

Ref: scylladb/scylla-enterprise#4284
Ref: scylladb/scylla-enterprise#4602
Ref: scylladb/scylla-enterprise#4588
@vponomaryov
Copy link
Contributor Author

vponomaryov commented Nov 22, 2024

Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants