-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(custom-d1-w2): mgmt-repair
+ tombstone_gc=repair
+ HH
+ log_batch
#9334
Merged
fruch
merged 2 commits into
scylladb:master
from
vponomaryov:custom-d1-w1--tombstone-gc
Nov 25, 2024
Merged
test(custom-d1-w2): mgmt-repair
+ tombstone_gc=repair
+ HH
+ log_batch
#9334
fruch
merged 2 commits into
scylladb:master
from
vponomaryov:custom-d1-w1--tombstone-gc
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latte allows to provide custom parameters to rune scripts. Latte creates schema using separate 'latte schema' command which we call implicitly. So, add possibility to specify custom parameters for the implicit call of the 'latte schema' command. Usage in a config file: latte_schema_parameters: tombstone_gc_mode: repair or as part of the env var: export SCT_LATTE_SCHEMA_PARAMETERS.tombstone_gc_mode=repair
Add test that uses 'custom-d1/workload2' scenario configuration and add following changes: - Set 'tombstone_gc' mode to be 'repair' - Enable 'mgmt_repiar' nemesis - Enable hinted_handoff feature - Use logged batch queries All of the above will allow to repro following bugs: Ref: scylladb/scylla-enterprise#4284 Ref: scylladb/scylla-enterprise#4602 Ref: scylladb/scylla-enterprise#4588
vponomaryov
added
backport/2024.1
Need backport to 2024.1
backport/2024.2
Need backport to 2024.2
backport/6.1
Need backport to 6.1
backport/6.2
backport/perf-v16
Ready for review
labels
Nov 22, 2024
Depends on the following PR: Tested here:
|
fruch
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
roydahan
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
Closed
Merged
scylladbbot
added
backport/2024.2-done
Commit backported to 2024.2
backport/6.2-done
backport/perf-v16-done
backport/6.1-done
Commit backported to 6.1
and removed
backport/2024.2
Need backport to 2024.2
backport/6.2
backport/perf-v16
backport/6.1
Need backport to 6.1
labels
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/perf-v16-done
backport/6.1-done
Commit backported to 6.1
backport/6.2-done
backport/2024.1
Need backport to 2024.1
backport/2024.2-done
Commit backported to 2024.2
promoted-to-master
Ready for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test that uses
custom-d1/workload2
scenario configuration and add following changes:tombstone_gc
mode to berepair
mgmt_repiar
nemesishinted_handoff
featurelogged batch
queriesAll of the above will allow to repro following bugs:
Ref: https://github.com/scylladb/scylla-enterprise/issues/4284
Ref: https://github.com/scylladb/scylla-enterprise/issues/4602
Ref: https://github.com/scylladb/scylla-enterprise/issues/4588
Testing
tombstone_gc=repair
: scylla-staging/valerii/vp-longevity-gce-custom-d1-workload2-hybrid-raid-repair#4tombstone_gc=disabled
: scylla-staging/valerii/vp-longevity-gce-custom-d1-workload2-hybrid-raid-repair#5PR pre-checks (self review)
backport
labelsReminders
sdcm/sct_config.py
)unit-test/
folder)