Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gce-backend): replace GCP instance types n1 with n2 #9332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gce-backend): replace GCP instance types n1 with n2 #9332

wants to merge 1 commit into from

Conversation

dimakr
Copy link
Contributor

@dimakr dimakr commented Nov 21, 2024 •
edited
Loading

Closes: #8971

Testing

couple of tests where n2 instances are used:

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevant to this change (if needed)

@dimakr dimakr marked this pull request as ready for review November 21, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roydahan roydahan roydahan approved these changes

@fruch fruch Awaiting requested review from fruch

At least 2 approving reviews are required to merge this pull request.

Assignees

@dimakr dimakr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace GCP instance types n1 with n2
2 participants
@dimakr @roydahan