fix(docker-backend): do not start scylla-manager installation #9331
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruch
reviewed
Nov 21, 2024
sdcm/cluster.py
Outdated
| @@ -5497,6 +5497,8 @@ def node_startup(self, node, **kwargs): # pylint: disable=unused-argument | |||
| pass | |||
|
|
|||
| def install_scylla_manager(self, node): | |||
| if node.is_docker(): | |||
There was a problem hiding this comment.
If you really want to fail fast
This should be checked in sct_config.py
There was a problem hiding this comment.
right, that would be faster)
dimakr
force-pushed
the
docker_backend_sudo_9028
branch
from
83c049d
to
0239b2c
Compare
|
@asias AFAIR you need to test repair - is that correct? |
dimakr
force-pushed
the
docker_backend_sudo_9028
branch
4 times, most recently
from
bb145f6
to
f43ab7a
Compare
If scylla-manager is not disabled in a test config when running a test on docker backend, the test will try to install the manager and eventually fail (this is due to the fact that SCT installs scylla-manager server on monitor node and docker backend doesn't support dedicated monitoring node docker instance). The change adds a check for this situation, to be able to fail fast and do not continue uch a test configuration on docker backend. Closes: scylladb#9028
dimakr
force-pushed
the
docker_backend_sudo_9028
branch
from
f43ab7a
to
8301de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If scylla-manager is not disabled in a test config when running a test on docker backend, the test will try to install the manager and eventually fail (this is due to the fact that SCT installs scylla-manager server on monitor node and docker backend doesn't support dedicated monitoring node docker instance).
The change adds a check for this situation, to be able to fail fast and do not continue with manager installation on docker backend.
Closes: #9028
Testing
PR pre-checks (self review)
backportlabelsReminders
sdcm/sct_config.py)unit-test/folder)