-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(operator.py): Increased timeout for get_mgr_backup_task method #8475
fix(operator.py): Increased timeout for get_mgr_backup_task method #8475
Conversation
…r_backup_task method
da9f3f6
to
f8e5b14
Compare
Isn't it something to raise in the operator side - why creating a backup task takes 8 minutes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zimnx might not be aware of the timeout value. |
it's a known issue that creating tasks takes long time. We have multiple issues with improvements (scylladb/scylla-operator#1939). Recent Manager 3.3.1 brought important feature which will help us resolve subset of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ugh, I didn't see missing backport labels. |
We don't have dedicated operator branches. It gets run with SCT master branch only. |
Some of the longevity tests for the Operator (e.g., longevity-scylla-operator-3h-eks-backup-test) are failing because they exceed the 300 second timeout set in the get_mgr_backup_task method. After investigation, I noticed that this operation can take up to approximately 8 minutes, so I increased the timeout to 10 minutes. Link to successful run after increasing timeout here