Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start release 1.1.0 #376

Closed
wants to merge 2 commits into from
Closed

start release 1.1.0 #376

wants to merge 2 commits into from

Conversation

giovp
Copy link
Member

@giovp giovp commented Jun 30, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (change that would cause existing functionality to not work as before)
  • New feature (non-breaking change which adds functionality)

Description

Addresses #366

How has this been tested?

...

Closes

...

@giovp
Copy link
Member Author

giovp commented Jun 30, 2021

your solution with raw worked @michalk8 but did not render on pypi (failed tox -e readme failed).
following this: github/markup#163
it seems that the image.. rst directive is correct in pypi but wrong in git. I would therefore stick to that and nevermind for not aligning in the github readme (where we could even remove the large image in the first place tbh.)
also the image figure1.png will be different when we merge dev to master (correct updated version)

@michalk8
Copy link
Collaborator

michalk8 commented Jun 30, 2021

your solution with raw worked @michalk8 but did not render on pypi (failed tox -e readme failed).
following this: github/markup#163

@giovp Let's move this to #377 - I was working on this when you opened this draft PR - it should be fixed there.

@giovp
Copy link
Member Author

giovp commented Jun 30, 2021

ok great! I will add these changes there

@michalk8
Copy link
Collaborator

closed in favor of #377

@michalk8 michalk8 closed this Jun 30, 2021
@michalk8 michalk8 deleted the start_release branch July 3, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants