-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make obs names unique #133
Conversation
Unfortunately I don't thinks this implementation is correct because, in Visium, the obs are made unique after the old column is used to for the index of the shapes. I will change this to call Also, in Visium HD we use integers for the instance_key column, so there is no need to make the obs names unique; I will remove that. Ideally, Visium and Visium HD should either both have integers of strings as names. But the matching between shapes and tables works in both case, and for backward compatibility it is probably better to keep things as they are now. |
@melonora if it looks good to you please proceed with merging. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
==========================================
- Coverage 36.17% 36.10% -0.07%
==========================================
Files 19 19
Lines 1692 1695 +3
==========================================
Hits 612 612
- Misses 1080 1083 +3
|
@melonora quick release note would be great thanks! |
pre-commit.ci run |
make obs names unique
This PR should fix the issue reported here. Also added a warning of the operation being performed. We could optionally leave that out.