Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xarray datatree support #329

Merged
merged 19 commits into from
Nov 26, 2024
Merged

Conversation

melonora
Copy link
Collaborator

@melonora melonora commented Nov 4, 2024

This PR adds utility functions to support the transition to xarray version that includes direct support for DataTree with the datatree library being archived. Quite some methods are not available at the DataTree level anymore, some of which were being used in napari-spatialdata.

The decorator from scverse/spatialdata#752 is being used here to apply transpose and reindexing on the DataTree structure that we support. Tests pass locally.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 66.49%. Comparing base (69105e0) to head (36633ba).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/napari_spatialdata/_widgets.py 40.00% 3 Missing ⚠️
src/napari_spatialdata/_scatterwidgets.py 0.00% 1 Missing ⚠️
src/napari_spatialdata/_viewer.py 66.66% 1 Missing ⚠️
src/napari_spatialdata/utils/_utils.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   63.08%   66.49%   +3.40%     
==========================================
  Files          19       19              
  Lines        2636     2701      +65     
==========================================
+ Hits         1663     1796     +133     
+ Misses        973      905      -68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucaMarconato LucaMarconato merged commit 914e540 into scverse:main Nov 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants