anndata 0.8 compat #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lol, maybe point me at a trivial change to make so I can get CI here |
Open
|
Some of the stuff from #7 is going to get broken by scverse/anndata#554, which I think I'll merge tomorrow. Hopefully no release has been made? I think it'd make sense to only release with that once the next anndata release is out. |
|
Thanks for the heads-up, I expect we'll have |
- Require anndata >= 0.8 - Replace read_attribute (deprecated) with read_elem - Version 0.2.0
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
|
@ivirshup Seems to work now, both with HDF5 and Zarr. In case you might want to take a look if there are no glaring omissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR which aiming to make mudata compatible with anndata 0.8. Ideally it will also be compatible with 0.7 and will have as few changes as possible.