-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOML formatting using pyproject-fmt #299
Conversation
A PR has been generated to the instance repo: You can check out the PR to preview your changes |
I like it in principle! Shall we wait a bit longer until the biome-pre-commit and pyproject-fmt are maturing a bit more? |
I think pyproject-fmt is mature enough, for biome-pre-commit we should maybe wait until someone replies to my comment in biomejs/pre-commit#5
it’s a completely separate rust project, and targets a different type of file, so maybe not that likely? but then again the ruff people have adopted |
Moved the biome part of this to #304 |
976492c
to
eeda0bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd (slightly) prefer this one over taplo - In addition to the reasons you mentioned it
- doesn't require another
.<formatter>
config file - seems to do more stuff that's specific to pyproject.toml, but useful (such as sorting dependencies)
OK! Do you think we should leave it unconfigured (2 spaces indent) or add [tool.pyproject-fmt]
indent = 4 for the taplo branch, I configured it because the diff would be minimal, but this PR will probably result in
|
Welp, we should decide on indents before next release, but I’m going to merge this |
Fixes #212
An alternative to #225, see #212 for a comparison