Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GH actions benchmark run #1730

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fix GH actions benchmark run #1730

merged 4 commits into from
Oct 22, 2024

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Oct 22, 2024

I’m also checking if the benchmark machine still does its job but I have no real reason to think it doesn‘t.

/edit: yup, sure works

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (6dfe780) to head (9002c63).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1730      +/-   ##
==========================================
- Coverage   86.93%   84.45%   -2.49%     
==========================================
  Files          40       40              
  Lines        6039     6039              
==========================================
- Hits         5250     5100     -150     
- Misses        789      939     +150     

see 8 files with indirect coverage changes

@flying-sheep flying-sheep added this to the 0.10.10 milestone Oct 22, 2024
@flying-sheep flying-sheep changed the title Attempt to fix benchmark run Fix benchmark run Oct 22, 2024
@flying-sheep flying-sheep self-assigned this Oct 22, 2024
Copy link

Benchmark changes

Change Before [6dfe780] After [9002c63] Ratio Benchmark (Parameter)
- 1.3854074205574294 1.220926616915423 0.88 readwrite.H5ADReadSuite.track_read_full_memratio('pbmc3k')
- 274±20μs 244±0.7μs 0.89 sparse_dataset.SparseCSRContiguousSlice.time_getitem_adata((10000, 10000), 'alternating')

Comparison: https://github.com/scverse/anndata/compare/6dfe7805b4ee7e86ddb095032b5ad23b040fe1d8..9002c636b3e0efd82b2f8a0b0e71fb72f4e449e6
Last changed: Tue, 22 Oct 2024 15:23:36 +0000

More details: https://github.com/scverse/anndata/pull/1730/checks?check_run_id=31896682384

@flying-sheep flying-sheep changed the title Fix benchmark run Fix GH actions benchmark run Oct 22, 2024
@flying-sheep flying-sheep merged commit 437dbc8 into main Oct 22, 2024
30 of 33 checks passed
@flying-sheep flying-sheep deleted the fix-benchmark-run branch October 22, 2024 15:57
meeseeksmachine pushed a commit to meeseeksmachine/anndata that referenced this pull request Oct 22, 2024
flying-sheep added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants