-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
forces Raw move to CPU #1107
forces Raw move to CPU #1107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Is there a test case that needs updating to include whatever was failing before?
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1107 +/- ##
===========================================
- Coverage 84.76% 52.46% -32.31%
===========================================
Files 36 36
Lines 5128 5133 +5
===========================================
- Hits 4347 2693 -1654
- Misses 781 2440 +1659
Flags with carried forward coverage won't be shown. Click here to find out more.
|
for more information, see https://pre-commit.ci
@ivirshup I added two tests. I hope I put them into the right place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I made some minor changes
- I think it's a little confusing to have names from both
cupyx.scipy.sparse
andscipy.sparse
imported, so I've qualified their usage - I think
isspmatrix_csr
will be deprecated, so I've replaced it with an instance check
Hey,
so I found that the implementation I used to force Raw to the CPU was not covering all cases. I added a second check. I should now always move
.X
to the CPU.