Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: switch to use rococo node #802

Merged
merged 25 commits into from
Sep 19, 2024
Merged

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Sep 11, 2024

This PR updates the following:

  • Switches CI testing node to polkadot docker image, which is regularly updated and uses ../latest. The dev runtime is rococo.
  • Added a new Runtime Config, which matches the rococo polkadot runtime:
pub type RococoRuntimeConfig = WithAddress<DefaultRuntimeConfig, MultiAddress<AccountId32, ()>>;
  • Default Runtime was switched to be the "original" defined one. This makes the generation of the rococo_runtime_config a little bit more comprehensible / traceable.
  • The following tests were removed:
  • Created a new wasm binary for the runtime upgrade: needed a higher spec version (must be higher than the original one) and a renaming of the runtime (needs to have the same name as the old one)

closes #778

@haerdib haerdib self-assigned this Sep 11, 2024
@haerdib haerdib changed the title Switch to westend runtime Examples: switch to use rococo node Sep 12, 2024
@haerdib haerdib marked this pull request as ready for review September 16, 2024 06:58
@haerdib haerdib requested review from Niederb and masapr September 16, 2024 08:15
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes. I think it makes sense to use the rococo runtime as this one should be better maintained.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have documentation on how to get this file and what version this currently is?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it myself. But effectively it can be any runtime, as long as the spec_version is higher than the original one and the runtime name matches the old one. I only took the minimal one to make sure it builds faster.

Should I add a documentation for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have some documentation 👍


println!("[+] Alice's Account Nonce is {}", api.get_nonce().await.unwrap());

let wasm = include_bytes!("flipper.wasm").to_vec();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think flipper.wasm is not used anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@haerdib haerdib requested a review from Niederb September 19, 2024 12:01
Copy link
Contributor

@Niederb Niederb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for the updated documentation 👍

@haerdib haerdib merged commit c12b735 into master Sep 19, 2024
59 checks passed
@haerdib haerdib deleted the bh/778-use-polkadot-node branch September 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use substrate image, that is kept up-to-date
2 participants