Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WithExtrinsicParams to use ExtrinsicSigner<Self> #698

Merged
merged 11 commits into from
Dec 22, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Dec 19, 2023

  • Updates WithExtrinsicParams to use the ExtrinsicSigner<Self> instead of the T::ExtrinsicSigner, which is defined as ExtrinsicSigner<Self> but with the other runtime.
  • Simplifies examples to use into() instead of more verbose ExtrinsicSigner::new
  • Use ExtrinsicSigner with DefaultRuntimeConfig on chain_tests.rs. Reasoning: Does not need a real signer, but it still ensures that DefaultRuntimeConfig is tested atleast as a Getter.

Fixes #628

@haerdib haerdib self-assigned this Dec 19, 2023
@haerdib haerdib added F2-bug Something isn't working E1-breaksnothing labels Dec 19, 2023
@haerdib haerdib marked this pull request as ready for review December 19, 2023 12:40
@haerdib haerdib requested a review from Niederb December 19, 2023 12:40
@haerdib haerdib requested a review from masapr December 22, 2023 12:25
Copy link
Collaborator

@masapr masapr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haerdib haerdib merged commit 724f7c3 into master Dec 22, 2023
51 checks passed
@haerdib haerdib deleted the bh/628-default-runtime-config branch December 22, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1-breaksnothing F2-bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultRuntimeConfig in ExtrinsicSigner::<..> does not work
2 participants