Add Siemens TD-3511 #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for this valuable contribution. At the moment I'm a bit occupied but I will gladly review and integrate it when I find some time. At first glace, it looks very neat! |
raymar9
requested changes
Sep 9, 2024
|
It seems that you haven't pushed your changes since my review. |
|
I haven‘t pushed yet. I want to test the setter for the baudrate first. I believe I have tried but not sure anymore. I guess I will be able to do it during the next few days.
Best regards
Christoph
Von meinem iPhone gesendet
Am 19.09.2024 um 17:13 schrieb Mario C ***@***.***>:
It seems that you haven't pushed your changes since my review.
—
Reply to this email directly, view it on GitHub<#69 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ARLJXSZ6CSKLIJLLSMZYVEDZXLSHFAVCNFSM6AAAAABMSW4GPGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRRGI4DQOJWGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Pushed the changes as commented |
raymar9
reviewed
Sep 23, 2024
raymar9
reviewed
Sep 23, 2024
raymar9
reviewed
Sep 23, 2024
|
Commited as 'Codereview raymar9 v2' as commmented above. |
raymar9
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compatibility with Siemens TD-3511 (first generation smartmeter, communicating over a serial IR-interface according to IEC62056-21, Mode C). Payload is not encrypted.
Changes are collected in one file and include a derived Meter class as well as a derived Reader class. The reading process is quite meter specific.
Code has been tested for several months without issues on an installed device in the supply area of IBW in Wohlen (Update rate ~5s).
I would appreciate you considering the request.