forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollup-verifier): support codecv1 #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thegaram
reviewed
Mar 25, 2024
colinlyguo
force-pushed
the
feat-rollup-verifier-codecv1
branch
from
March 26, 2024 12:31
2d13fe6
to
92e7f00
Compare
colinlyguo
force-pushed
the
feat-rollup-verifier-codecv1
branch
from
March 26, 2024 12:32
92e7f00
to
faf167a
Compare
Tested the backward compatibility by running a local follower node with |
georgehao
previously approved these changes
Mar 27, 2024
0xmountaintop
previously approved these changes
Mar 28, 2024
0xmountaintop
previously approved these changes
Apr 2, 2024
georgehao
previously approved these changes
Apr 3, 2024
github-actions
bot
dismissed stale reviews from 0xmountaintop and georgehao
via
April 4, 2024 08:10
e024e56
georgehao
previously approved these changes
Apr 4, 2024
0xmountaintop
previously approved these changes
Apr 4, 2024
Tested |
georgehao
approved these changes
Apr 4, 2024
0xmountaintop
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Support codecv1 in rollup-verifier.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?