Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rollup-verifier): support codecv1 #678

Merged
merged 31 commits into from
Apr 4, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Mar 25, 2024

1. Purpose or design rationale of this PR

Support codecv1 in rollup-verifier.

  • Add unit tests.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

rollup/types/encoding/da.go Outdated Show resolved Hide resolved
rollup/types/encoding/codecv0/codecv0.go Outdated Show resolved Hide resolved
@colinlyguo colinlyguo force-pushed the feat-rollup-verifier-codecv1 branch from 2d13fe6 to 92e7f00 Compare March 26, 2024 12:31
@colinlyguo colinlyguo force-pushed the feat-rollup-verifier-codecv1 branch from 92e7f00 to faf167a Compare March 26, 2024 12:32
@colinlyguo
Copy link
Member Author

Tested the backward compatibility by running a local follower node with --rollup.verify flag.

georgehao
georgehao previously approved these changes Mar 27, 2024
0xmountaintop
0xmountaintop previously approved these changes Mar 28, 2024
0xmountaintop
0xmountaintop previously approved these changes Apr 2, 2024
georgehao
georgehao previously approved these changes Apr 3, 2024
@github-actions github-actions bot dismissed stale reviews from 0xmountaintop and georgehao via e024e56 April 4, 2024 08:10
georgehao
georgehao previously approved these changes Apr 4, 2024
0xmountaintop
0xmountaintop previously approved these changes Apr 4, 2024
@colinlyguo colinlyguo dismissed stale reviews from 0xmountaintop and georgehao via 0fa2d2a April 4, 2024 08:19
@colinlyguo
Copy link
Member Author

Tested codecv0 in Sepolia, codecv1 testing TBD.

@0xmountaintop 0xmountaintop merged commit 55b03ff into develop Apr 4, 2024
7 checks passed
@0xmountaintop 0xmountaintop deleted the feat-rollup-verifier-codecv1 branch April 4, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants