Switch case from conditional statement to determine keyboard width

[mcrkgus]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the xcodebuild and swiftlint --strict commands as directed in the testing section of the contributing guide

---

Description

Switch from conditional statements to switch and case statements to determine the keyboard width.

switch key {
     case "ABC", "АБВ":
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * 1).isActive = true
    case "#+=", "selectKeyboard":
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarSpecialKeysWidth).isActive = true
     case "delete":
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarDeleteKeyWidth).isActive = true
     case SpecialKeys.capsLock:
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarCapsLockKeyWidth).isActive = true
     case SpecialKeys.indent:
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarIndentKeyWidth).isActive = true
     case "shift" where idx == 0:
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarShiftKeyWidth).isActive = true
     case "shift" where idx > 0:
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarRightShiftKeyWidth).isActive = true
     case "return":
       layer.setValue(true, forKey: "isSpecial")
       widthAnchor.constraint(equalToConstant: numSymKeyWidth * scalarReturnKeyWidth).isActive = true
     case "123", ".?123", "return", "hideKeyboard":
       if DeviceType.isPad
           && key == "return"
           && ((commandState != .translate && ["English", "Portuguese", "Italian"].contains(controllerLanguage)) ||
               (commandState == .translate && ["en", "pt", "it"].contains(getControllerTranslateLangCode())))
           && row == 1 {
         layer.setValue(true, forKey: "isSpecial")
         widthAnchor.constraint(equalToConstant: numSymKeyWidth * 1.5).isActive = true
       } else {
         layer.setValue(true, forKey: "isSpecial")
         widthAnchor.constraint(equalToConstant: numSymKeyWidth * 1).isActive = true
       }
}

Related issue

• Transition away from switch case for determining keyboard layouts #525

[github-actions]

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

• The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

• The CI unit test workflows within the PR checks do not indicate new errors in the files changed

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[github-actions]

First PR Commit Check

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
• The contributor's name and icon in remote commits should be the same as what appears in the PR
• If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo (can be set with git config --global user.email "GITHUB_EMAIL")

[andrewtavis]

Thanks much for the PR! Could you do a refactor to make sure that we don't have "return" in two different switch cases, @mcrkgus? We should be good to go at that point :)

[mcrkgus]

@andrewtavis
I have revised and reflected the parts you mentioned! Please check. Thank you 😊

[andrewtavis]

Fantastic, @mcrkgus! I'm for a few days till the 26th, so I won't be able to do a final review until then. @Jag-Marcel, if you have a moment, would you be able to take a look at this? If you're ok with it I can then merge, or feel free to +1 and I'll finalize it when I'm back :)

@mcrkgus, from here you'd be welcome to continue any further work for #399 and #525. What are the next steps you're planning?

[Jag-Marcel]

I'll take a look tomorrow morning 👍

[Jag-Marcel]

All looks good to me, works fine on all keyboards still and this is much simpler and easier to read, good work @mcrkgus!
@andrewtavis I think this is good to be merged

[Jag-Marcel]

@andrewtavis On a more unrelated note, I noticed that on iPad, the key width in landscape is all over the place. If you start a keyboard on landscape, the keys change width slightly when switching from letter keys to symbols. If you start on portrait, all special keys remain weirdly thin in landscape, the regular keys start out normal albeit with more space between them, but when you switch to symbols they are really thin.
This doesn't have anything to do with the changes in this PR I think, it's also a problem on the main branch.

Is there already an issue for this that I missed, or do you want me to make one?

[andrewtavis]

There's no issue for this so far, @Jag-Marcel :) Would be great if you made one and included some screenshots.

[andrewtavis]

Thanks for the great first contribution, @mcrkgus! Hope we can get another PR from you again soon :) Please let us know what the next steps are for the issues you're working on 😊