-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completed the HECommandVariables file #497
Completed the HECommandVariables file #497
Conversation
Completed the HE file from the EN version. Added all the translations for the needed terms.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Minor suggestions on your PR workflow for the next time, @DanielGevaZA :)
|
Also I'm realizing that for this it'd make sense for us to be working on the Scribe-Data issue for this as well now, as we're trying to set up commands, but we haven't set out what the verb tenses are going to be for conjugate :) Would you want to update the Wikidata query for Hebrew verbs at the following link (directions below): You can find a Hebrew verb on Wikidata via a special search with From there, could you let me know what you'd say would be the ideal verb tenses to get from a verb like the following (as I understand it it's something like "to write", which should have good conjugation coverage): And then we can reference the queries for other languages to get all their verbs and edit the Hebrew verbs query so that it returns all the conjugations we need 😊 Once we have that set, we'll then have a better understanding of what data we're trying to model, and then we can update the PR here so that all the conjugations will have appropriate setups. |
} | ||
} | ||
|
||
/// What the conjugation state is for the conjugate feature. | ||
enum HEConjugationState { | ||
case present | ||
case presSimp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here we'll need to update this list based on what conjugations we'll get from Wikidata :)
func heConjugationStateLeft() {} | ||
func heConjugationStateLeft() { | ||
switch heConjugationState { | ||
case .present, .presSimp, .presCont, .presPerf, .presPerfCont, .pastCont: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should specifically only have one tense for each case
statement :)
Do you want to continue on this issue now, @DanielGevaZA? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through and added in the conjugation flow to this PR here, @DanielGevaZA :) We can pick this up further once the data is added into the project. We're also working on RTL support for the menu, with this laying the groundwork for the same for the keyboards.
Thanks for this!
Contributor checklist
Description
Completed the HE file from the EN version. Added all the translations for the needed terms.
Related issue