Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modal for adding a pipeline to a collection #1084

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

minghay
Copy link
Contributor

@minghay minghay commented Jul 10, 2024

Context

Provides a new modal to add a pipeline to a collection or multiple collections as part of the new UI changes. This modal provides an improved UX as users can:

  1. Create a new collection with the pipeline added to the collection in the modal
  2. Add the pipeline to multiple pipelines at once
  3. Do 1 and 2 from above in the same operation

Objective

Create a new modal that allows users to add a pipeline to collections. Collections that already contain the pipeline are not displayed in the modal.

Modal when there are no existing collections for the user
Screenshot 2024-07-09 at 16-14-09 New Pipeline Events Show

Modal when the user has collections already created.
Screenshot 2024-07-09 at 16-10-53 New Pipeline Events Show

Modal displaying an error
Screenshot 2024-07-09 at 16-11-17 New Pipeline Events Show

Modal displaying multiple errors (by multiple errors, this means that a new collection was desired to be created and the user also wanted to add the pipeline to some existing collection(s))
Screenshot 2024-07-09 at 16-11-49 New Pipeline Events Show

References

screwdriver-cd/screwdriver#3200

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@minghay minghay merged commit 8d04c6f into master Jul 11, 2024
2 checks passed
@minghay minghay deleted the v2-add-to-collection-modal branch July 11, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants