feat: New pipeline parameters component #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minghay
force-pushed
the
new-pipeline-parameters-component
branch
from
d7119f9 to
7543c8e
Compare
|
Nitpicky comment but can we make the dropdown and the other form have the same style? border-radius and padding looks different to me |
c53532c updates the style so that the input field matches the dropdown selector
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
#1065 added a new Glimmer component that wraps Ember Power Select for the use with pipeline/job parameters. This new Glimmer component wraps up all pipeline/job parameters into a single entity that has some styles applied and some basic user interactions. Conceptually, users will interact with this component and modify parameters and any changes to these parameters are made available to a parent component via the
@onUpdateParametersargument.Objective
Provide a new Glimmer component that is compatible with the new UI. There are some minor CSS changes to what exists in the old UI, but it's largely the same.
References
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.