Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: convert to GitHub Actions, update links #28

Merged
merged 7 commits into from
Oct 31, 2023
Merged

ci: convert to GitHub Actions, update links #28

merged 7 commits into from
Oct 31, 2023

Conversation

cwillisf
Copy link
Contributor

@cwillisf cwillisf commented Sep 28, 2023 •
edited
Loading

Resolves

  • Resolves ENA-47

Proposed Changes

  • Convert to GHA
  • Update repository links in package.json for LLK -> scratchfoundation
  • Replace build status badge in README.md with GHA build badge
  • Remove --colors from the webpack calls in package.json because webpack can detect whether or not to use colors
  • Finish half-installed eslint configuration and fix lint errors (including CRLF -> LF in src/index.js)
  • Use semantic-release and accompanying spiffs

@cwillisf cwillisf requested review from a team and AlexisGoodfellow and removed request for a team September 28, 2023 22:02
@cwillisf cwillisf removed the request for review from AlexisGoodfellow October 17, 2023 22:16
@cwillisf cwillisf requested review from a team and colbygk and removed request for a team October 17, 2023 23:29
AlexisGoodfellow
AlexisGoodfellow approved these changes Oct 31, 2023
View reviewed changes
Copy link

@AlexisGoodfellow AlexisGoodfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hadn't heard of .editorconfig before. Looks like there's a vim plugin for it. Neat!

Other than that, nothing unexpected as far as I can see. Make it so!

@cwillisf cwillisf merged commit 3e518d9 into master Oct 31, 2023
1 check passed
@cwillisf cwillisf deleted the gha branch October 31, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexisGoodfellow AlexisGoodfellow AlexisGoodfellow approved these changes

@colbygk colbygk Awaiting requested review from colbygk colbygk was automatically assigned from scratchfoundation/scratch-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwillisf @AlexisGoodfellow