Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rsmq-async to version 8 #1711

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Upgrade rsmq-async to version 8 #1711

merged 2 commits into from
Nov 20, 2023

Conversation

emmiegit
Copy link
Member

The new version was announced in DavidBM/rsmq-async-rs#17. The main code change for our PR is changing integers (seconds) to std::time::Duration.

@emmiegit emmiegit self-assigned this Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #1711 (a6fc802) into develop (2abfe6f) will increase coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1711      +/-   ##
===========================================
+ Coverage    39.51%   39.56%   +0.04%     
===========================================
  Files          342      342              
  Lines        10980    10984       +4     
===========================================
+ Hits          4339     4346       +7     
+ Misses        6641     6638       -3     
Flag Coverage Δ *Carryforward flag
deepwell 2.01% <0.00%> (-0.02%) ⬇️
ftml 76.83% <ø> (+0.14%) ⬆️ Carriedforward from e623ac2

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
deepwell/src/config/object.rs 0.00% <ø> (ø)
deepwell/src/services/job/service.rs 0.00% <ø> (ø)
deepwell/src/redis.rs 0.00% <0.00%> (ø)
deepwell/src/config/file.rs 8.23% <0.00%> (-0.41%) ⬇️
deepwell/src/services/job/worker.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

@emmiegit emmiegit merged commit 64e9f7e into develop Nov 20, 2023
9 checks passed
@emmiegit emmiegit deleted the rsmq-async-version branch November 20, 2023 03:17
@emmiegit
Copy link
Member Author

thanks @Yossipossi1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants