Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace async-std with tokio #1710

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Replace async-std with tokio #1710

merged 1 commit into from
Nov 17, 2023

Conversation

emmiegit
Copy link
Member

This was one part of the RPC transition that was left behind, so I'm doing it here. With this, we don't directly depend on async-std anymore and instead use tokio for this and our main dependencies.

Forgot to transition this when we replaced tide with RPC.
@emmiegit emmiegit self-assigned this Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #1710 (2abfe6f) into develop (ebeb0c2) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1710      +/-   ##
===========================================
+ Coverage    39.47%   39.51%   +0.04%     
===========================================
  Files          343      342       -1     
  Lines        10993    10980      -13     
===========================================
  Hits          4339     4339              
+ Misses        6654     6641      -13     
Flag Coverage Δ *Carryforward flag
deepwell 2.03% <0.00%> (+<0.01%) ⬆️
ftml 76.69% <ø> (ø) Carriedforward from ebeb0c2

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
deepwell/src/services/render/service.rs 0.00% <ø> (ø)
deepwell/src/services/password.rs 0.00% <0.00%> (ø)
deepwell/src/locales/fluent.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@emmiegit
Copy link
Member Author

thanks @Yossipossi1

@emmiegit emmiegit merged commit 0f38b2a into develop Nov 17, 2023
8 checks passed
@emmiegit emmiegit deleted the async-std branch November 17, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants