-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use user locale preferences in view, allow multiple locales #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can get user locale, if present.
This way we always prefer the user's settings over the browser's request.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1702 +/- ##
===========================================
- Coverage 39.59% 39.55% -0.05%
===========================================
Files 343 343
Lines 10975 10990 +15
===========================================
+ Hits 4346 4347 +1
- Misses 6629 6643 +14
*This pull request uses carry forward flags. Click here to find out more.
|
Yossipossi1
approved these changes
Nov 14, 2023
thanks @Yossipossi1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One design goal is to allow multi-lingual users to specify multiple locales (in a specific order) that they want to see used if a previous locale is not available, so this change both uses the locales specified by the user in the localization order before using the browser
Accept-Language
setting, and changes the database so that theuser.locales
column isTEXT[]
instead ofTEXT
.This also requires that messages pass in a locale they want the message to be rendered as, since with multiple locales per user, we cannot assume any particular one in message drafting.
This does not address the case where the user is not logged in and there is no
Accept-Language
header, which will need to be fixed in another PR.