-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WJ-1200] Add "site users" #1692
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1692 +/- ##
===========================================
- Coverage 40.04% 39.62% -0.42%
===========================================
Files 342 343 +1
Lines 10853 10967 +114
===========================================
Hits 4346 4346
- Misses 6507 6621 +114
*This pull request uses carry forward flags. Click here to find out more.
|
Yossipossi1
approved these changes
Nov 9, 2023
thanks @Yossipossi1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in WJ-1200, the "site user" is a special type of user which is created only when a site is, and represents it in totality. All such users have the name
site:[slug]
, for instancesite:scp-sandbox-3
. This allows us to do things with this virtual user such as sending staff messages from a standard account, forwarding messages received to different assigned staff members, and having one standard user to represent the site itself for matters such as "page whose attribution is staff".This implements this new user type, adds logic to create it when a site is created, and edits it when a site is edited. Because colons (
:
) are not normally allowed in user slugs, there is a special exception for this user type.