Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WJ-1189] Replace lazy_static with once_cell #1628

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Conversation

emmiegit
Copy link
Member

See also #1447. This replaces the lazy_static crate with once_cell in deepwell, as well as removing it from the wikidot-path/wikidot-normalize sub-dependencies.

@emmiegit emmiegit self-assigned this Sep 29, 2023
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #1628 (9fc4577) into develop (d5bde68) will decrease coverage by 0.01%.
The diff coverage is 34.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1628      +/-   ##
===========================================
- Coverage    42.58%   42.57%   -0.01%     
===========================================
  Files          329      329              
  Lines        10116    10120       +4     
===========================================
+ Hits          4308     4309       +1     
- Misses        5808     5811       +3     
Flag Coverage Δ *Carryforward flag
deepwell 1.60% <34.78%> (+0.02%) ⬆️
ftml 76.81% <ø> (ø) Carriedforward from d5bde68

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
deepwell/src/main.rs 0.00% <ø> (ø)
deepwell/src/services/blob/mime.rs 92.00% <100.00%> (ø)
deepwell/src/services/job/service.rs 0.00% <ø> (ø)
deepwell/src/services/user/service.rs 0.00% <0.00%> (ø)
deepwell/src/services/file_revision/service.rs 0.00% <0.00%> (ø)
deepwell/src/services/page_revision/service.rs 0.00% <0.00%> (ø)
deepwell/src/info.rs 41.17% <41.17%> (-1.69%) ⬇️

@emmiegit emmiegit merged commit 3b26d57 into develop Sep 29, 2023
8 checks passed
@emmiegit emmiegit deleted the WJ-1189-lazy_static branch September 29, 2023 22:01
@emmiegit
Copy link
Member Author

thanks @Yossipossi1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants