Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend related features [1] #1596

Merged
merged 26 commits into from
Sep 27, 2023
Merged

Frontend related features [1] #1596

merged 26 commits into from
Sep 27, 2023

Conversation

Zokhoi
Copy link
Contributor

@Zokhoi Zokhoi commented Sep 10, 2023 •
edited
Loading

This tracks the Jira issues and features for frontend I am trying to tackle.

Done:

  • WJ-1179 Add svelte component for page view
  • WJ-1155 First basic UI interaction to edit a page
  • Page creation, deletion, move
  • Page history
  • Sigma-esque page layout

@codecov
Copy link

codecov bot commented Sep 10, 2023 •
edited
Loading

Codecov Report

Merging #1596 (a22ae66) into develop (5aaf9f9) will decrease coverage by 0.03%.
Report is 51 commits behind head on develop.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1596      +/-   ##
===========================================
- Coverage    42.90%   42.87%   -0.03%     
===========================================
  Files          328      328              
  Lines        10041    10048       +7     
===========================================
  Hits          4308     4308              
- Misses        5733     5740       +7
Flag Coverage Δ *Carryforward flag
deepwell 1.60% <0.00%> (-0.01%) ⬇️
ftml 76.81% <ø> (ø) Carriedforward from c12985e

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
deepwell/src/services/view/service.rs 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

emmiegit
emmiegit reviewed Sep 10, 2023
View reviewed changes
deepwell/src/services/view/service.rs Outdated Show resolved Hide resolved
framerail/src/routes/+page.svelte Show resolved Hide resolved
framerail/src/routes/[slug]/[...extra]/+server.ts Outdated Show resolved Hide resolved
@Zokhoi Zokhoi marked this pull request as ready for review September 26, 2023 08:07
@Zokhoi Zokhoi requested a review from Monkatraz as a code owner September 26, 2023 08:07
@Zokhoi Zokhoi requested a review from emmiegit September 26, 2023 08:08
@Zokhoi
Copy link
Contributor Author

Zokhoi commented Sep 26, 2023 •
edited
Loading

Will have to merge these changes to dev for now and continue working off of the new changes in dev

@Zokhoi Zokhoi changed the title [In progress] Frontend related features Frontend related features Sep 26, 2023
@emmiegit
Copy link
Member

For framerail/src/lib/assets/wikijump-banner-solid.min.svg should it be in assets/?

@Zokhoi
Copy link
Contributor Author

Zokhoi commented Sep 26, 2023 •
edited
Loading

Probably yes, or in static/ or some other place. When I was including that I wasn't aware how to import from a path relative to project root or other custom directories. I think I could set up an alias for it in svelte or vite though.

@emmiegit
Copy link
Member

Sounds good, thanks. If it's not possible we should create a custom directory for frontend for assets. (Maybe symbolic links would work?)

emmiegit
emmiegit approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a lot of comments, but mostly fine to go. You can change these in a follow-up PR to maintain momentum.

framerail/src/lib/server/page/history.ts Outdated Show resolved Hide resolved
framerail/src/routes/+error.svelte Show resolved Hide resolved
framerail/src/routes/+error.svelte Outdated Show resolved Hide resolved
framerail/src/lib/server/page/edit.ts Outdated Show resolved Hide resolved
framerail/src/lib/server/page/edit.ts Show resolved Hide resolved
framerail/src/routes/[slug]/[...extra]/page.svelte
let options: string[] = []
if (data.options.noRender) options.push("norender")
options = options.map((opt) => `/${opt}`)
goto(`/${data.page.slug}${options.join("")}/edit`, {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should expose a method of converting options back into a URL path.

framerail/src/routes/[slug]/[...extra]/page.svelte Outdated Show resolved Hide resolved
framerail/src/routes/[slug]/[...extra]/page.svelte Show resolved Hide resolved
framerail/src/routes/[slug]/[...extra]/page.svelte Outdated Show resolved Hide resolved
framerail/src/routes/[slug]/[...extra]/page.svelte Outdated Show resolved Hide resolved
@Zokhoi Zokhoi merged commit dccba11 into scpwiki:develop Sep 27, 2023
8 checks passed
@Zokhoi Zokhoi deleted the frontend branch September 27, 2023 11:03
@Zokhoi Zokhoi changed the title Frontend related features Frontend related features [1] Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmiegit emmiegit emmiegit approved these changes

@Monkatraz Monkatraz Awaiting requested review from Monkatraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zokhoi @emmiegit