Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix SVG backgrounds in header on IE by explicitly setting full background-size" #94

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Revert "Fix SVG backgrounds in header on IE by explicitly setting full background-size" #94

merged 1 commit into from
Jan 11, 2024

Conversation

emmiegit
Copy link
Member

Reverts #93

According to @SYwaves:

Do not merge
We don’t want to add explicit sizing to bg size since it css change some pages on site that rely on intrinsic size of image
We also dropped ie support already, so it didn’t matter much

@SYwaves SYwaves merged commit 1aa08e7 into main Jan 11, 2024
2 checks passed
@SYwaves SYwaves deleted the revert-93-ie-svg-backgrounds branch January 11, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SYwaves SYwaves SYwaves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmiegit @SYwaves