Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preventing forum shenanigans + content isolation #91

Merged
merged 1 commit into from
Nov 16, 2023
Merged

preventing forum shenanigans + content isolation #91

merged 1 commit into from
Nov 16, 2023

Conversation

SYwaves
Copy link
Contributor

@SYwaves SYwaves commented Nov 16, 2023

Establish paint containment for forum posts.

@SYwaves
Copy link
Contributor Author

SYwaves commented Nov 16, 2023 •
edited
Loading

contain: paint creates a new containing block context, preventing position: fixed and z-index from being attached to the root html/viewport. Furthermore, it clips all content outside its bound and prevents overflow (like overflow: hidden).

@emmiegit emmiegit merged commit 6126e75 into main Nov 16, 2023
2 checks passed
@emmiegit emmiegit deleted the forum-comment-isolation branch November 16, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmiegit emmiegit emmiegit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYwaves @emmiegit