Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FromStr impl for Layout #19

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Add FromStr impl for Layout #19

merged 4 commits into from
Aug 2, 2024

Conversation

emmiegit
Copy link
Member

@emmiegit emmiegit commented Aug 2, 2024 •
edited
Loading

This implements FromStr, which allows us to do string_value.parse() to get a Layout enum, consistently parsing it for us.

It also fixes the #[cfg] conditions to correctly use debug_assertions, the actual compilation flag.

@emmiegit emmiegit self-assigned this Aug 2, 2024
@emmiegit
Copy link
Member Author

emmiegit commented Aug 2, 2024

thanks @Yossipossi1

@emmiegit emmiegit merged commit 23f499d into main Aug 2, 2024
6 checks passed
@emmiegit emmiegit deleted the layout-parse branch August 2, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yossipossi1 Yossipossi1 Yossipossi1 approved these changes

Assignees

@emmiegit emmiegit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmiegit @Yossipossi1