[WJ-1244] Add the concept of the "layout" to ftml #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0216984. We will add this to WikitextSettings instead.
This reverts commit d7257b6.
Yossipossi1
approved these changes
Jul 16, 2024
|
thanks @Yossipossi1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: WJ-1244
This adds the concept of "DOM layouts" to ftml. This is to help us resolve an issue we discussed in chat, where we need to emit Wikidot-compatible HTML in order to match with existing themes, but long-term we want a more sane and sensible DOM structure (e.g. using newer HTML5 constructs instead of
<div>everywhere).So part of this work involves adding the
Layoutenum to ftml, which we are adding inWikitextSettings. Then, as we update things, theHtmlRenderimplementation will be changed to emit different DOM elements depending on which layout is selected.