Request body is preserved across 'next' calls #147 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ocramz
commented
Sep 25, 2023
•
ocramz
commented
- added test case to confirm issue is still there
- adapted patch by @thomasjm https://github.com/scotty-web/scotty/pull/206/files to handle max body size parameter
- clarify imports in a few places
ocramz
changed the title
|
@RyanGlScott Hi, github suggested you as a reviewer :) the original bug (#147 ) is fixed, but CI fails due to an unrelated test: an exception raised by a too large request body is uncaught, which I find very puzzling since I didn't modify exception behaviour in this PR. Thanks for all pointers. |
ocramz
commented
Sep 26, 2023
| @@ -97,6 +97,14 @@ spec = do | |||
| it "returns 500 on exceptions" $ do | |||
| get "/" `shouldRespondWith` "<h1>500 Internal Server Error</h1>divide by zero" {matchStatus = 500} | |||
|
|
|||
| describe "setMaxRequestBodySize" $ do | |||
There was a problem hiding this comment.
moved this test to appear under the "ScottyM" section
This was referenced Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.